feat: Add 'Reveal in Java Projects' in editor titile context #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jdneo
commented
Sep 23, 2020
jdneo
commented
jdneo
requested review from
CsCherrYY,
Eskibear,
akaroml and
testforstephen
jdneo
commented
Sep 23, 2020
| }, | ||
| { | ||
| "command": "java.view.package.revealInProjectExplorer", | ||
| "when": "resourceExtname == .java && java:projectManagerActivated && java:serverMode == Standard", |
There was a problem hiding this comment.
paranthesis in "when" is not supported so here I split them into two part: microsoft/vscode#91473
jdneo
force-pushed
the
cs/editor-shortcut
branch
from
6a807ba to
2fb1b7e
Compare
| "explorer/context": [ | ||
| { | ||
| "command": "java.view.package.revealInProjectExplorer", | ||
| "when": "resourceFilename in java:supportedBuildFiles && java:projectManagerActivated && java:serverMode == Standard", |
There was a problem hiding this comment.
in java:supportedBuildFiles? or in supportedBuildFiles
There was a problem hiding this comment.
oh, it's a name convention you used.
testforstephen
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.